Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: refactorCeil and improved tests#6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DenizAltunkapan merged 9 commits intoTheAlgorithms:masterfromalxkm:refactor/ceil
Jul 14, 2025

Conversation

alxkm
Copy link
Contributor

@alxkmalxkm commentedJul 10, 2025
edited
Loading

Ceil Class Refactor:

  • Simplified the Ceil.ceil(double) method for better clarity and correctness.
  • Replaced (int) casting with (long) to handle edge cases and large numbers more safely.
  • Updated method-level JavaDoc and added class-level documentation for better understanding and maintainability.

Test Refactor:

  • Migrated CeilTest to use JUnit 5 @ParameterizedTest with @CsvSource.
  • Enhanced test readability, scalability, and coverage.
  • Ensures better structure and allows easier future additions of test cases.
  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted withclang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commentedJul 10, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is57.14286% with3 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base(ef93cc1) to head(cf176af).

Files with missing linesPatch %Lines
src/main/java/com/thealgorithms/maths/Ceil.java57.14%1 Missing and 2 partials⚠️
Additional details and impacted files
@@             Coverage Diff              @@##             master    #6366      +/-   ##============================================- Coverage     74.64%   74.63%   -0.02%- Complexity     5445     5450       +5============================================  Files           682      682                Lines         19000    19003       +3       Branches       3668     3669       +1     ============================================  Hits          14182    14182- Misses         4260     4261       +1- Partials        558      560       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapanDenizAltunkapan merged commit933e929 intoTheAlgorithms:masterJul 14, 2025
6 of 7 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DenizAltunkapanDenizAltunkapanDenizAltunkapan approved these changes

@yanglbmeyanglbmeAwaiting requested review from yanglbmeyanglbme is a code owner

@vil02vil02Awaiting requested review from vil02vil02 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@alxkm@codecov-commenter@DenizAltunkapan

[8]ページ先頭

©2009-2025 Movatter.jp