Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Compressed CPU algorithms(FirstFit, BestFit, WorstFit) to one "mother…#2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexlemo20
Copy link
Contributor

@alexlemo20alexlemo20 commentedFeb 5, 2022
edited
Loading

CPUalgorithms abstract - "mother" - runnable class

Describe your change:

Compressed CPU algorithms (First Fit, Best Fit, Worst Fit ) into one class. The class CPUalgorithms is abstract so that fitProcess and printMemoryAllocation methods are implemented in each algorithm differently. Use of inheritance among the class CPUalgorithms and the three algorithm's classes. The class CPUalgorithms is runnable in order to test algorithms.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Member

@siriaksiriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for contributing! Please remove the main() function and methods that write to console. Please also delete old files with algorithms that you have collected here and add some automated tests to test the algorithms, thanks!

Copy link
Member

@siriaksiriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, great job, thanks!

@siriaksiriak merged commitadadb2f intoTheAlgorithms:masterFeb 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@siriaksiriaksiriak approved these changes

@yanglbmeyanglbmeAwaiting requested review from yanglbmeyanglbme is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexlemo20@siriak

[8]ページ先頭

©2009-2025 Movatter.jp