- Notifications
You must be signed in to change notification settings - Fork20.7k
Compressed CPU algorithms(FirstFit, BestFit, WorstFit) to one "mother…#2935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
siriak left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for contributing! Please remove the main() function and methods that write to console. Please also delete old files with algorithms that you have collected here and add some automated tests to test the algorithms, thanks!
siriak left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, great job, thanks!
Uh oh!
There was an error while loading.Please reload this page.
CPUalgorithms abstract - "mother" - runnable class
Describe your change:
Compressed CPU algorithms (First Fit, Best Fit, Worst Fit ) into one class. The class CPUalgorithms is abstract so that fitProcess and printMemoryAllocation methods are implemented in each algorithm differently. Use of inheritance among the class CPUalgorithms and the three algorithm's classes. The class CPUalgorithms is runnable in order to test algorithms.
References
Checklist:
Fixes: #{$ISSUE_NO}.