- Notifications
You must be signed in to change notification settings - Fork20.7k
Fixes(#2877)#2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fixes(#2877)#2913
Uh oh!
There was an error while loading.Please reload this page.
Conversation
siddhant2002 commentedJan 22, 2022
@siriak please check the updated pr for maximum subarray sum |
siriak left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for contributing, this algorithm is already present herehttps://github.com/TheAlgorithms/Java/blob/9fb3364cccc5373c32dbdb661f773c5ee753c77a/src/main/java/com/thealgorithms/dynamicprogramming/KadaneAlgorithm.java as far as I can tell, but the old implementation is missing tests, so your improvements are welcome. Could you consolidate your and existing implementations into one?
| int a[]={-1}; | ||
| assertTrue(KadaneAlgorithm.max_Sum(a)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What does it mean? The purpose of the algorithm is to find the largest possible sum, why does it return bool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Basically it's checking with the predicted answer
794547955 commentedFeb 12, 2022 via email
这是来自QQ邮箱的假期自动回复邮件。 您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。 |
CrpMihasha commentedFeb 12, 2022 via email
亲，邮件已收到 |
Uh oh!
There was an error while loading.Please reload this page.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.