Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added sort list Algorithm#2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
siriak merged 18 commits intoTheAlgorithms:masterfromsiddhant2002:master
Jan 19, 2022
Merged

Added sort list Algorithm#2882

siriak merged 18 commits intoTheAlgorithms:masterfromsiddhant2002:master
Jan 19, 2022

Conversation

@siddhant2002
Copy link
Contributor

@siddhant2002siddhant2002 commentedDec 20, 2021•
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

Copy link
Member

@siriaksiriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No need to include string compare algorithms, please replace main() with tests as inhttps://github.com/TheAlgorithms/Java/blob/98656cb0cdacd175559272bcbb8bc3b86ddac52a/src/test/java/com/thealgorithms/maths/KaprekarNumbersTest.java and improve formatting

@siddhant2002
Copy link
ContributorAuthor

@siriak Please check the updated pr

Copy link
Member

@siriaksiriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The formatting is much better, but you still need to replace main() with automated tests as mentioned in the previous review

@siddhant2002
Copy link
ContributorAuthor

@siriak Please check the updated pr

@zhrgithub
Copy link

zhrgithub commentedJan 19, 2022 via email

ok| |张泓锐||***@***.***|签名由网易邮箱大师定制在2022年01月19日 12:28，Siddhant Swarup ***@***.***> 写道：@siriak Please check the updated pr—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Copy link
Member

@siriaksiriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks!

@siriaksiriak merged commit857c4aa intoTheAlgorithms:masterJan 19, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@siriaksiriaksiriak approved these changes

@yanglbmeyanglbmeAwaiting requested review from yanglbmeyanglbme is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddhant2002@zhrgithub@siriak
[8]ページ先頭
©2009-2025 Movatter.jp