- Notifications
You must be signed in to change notification settings - Fork20.7k
MaximumSubArraySum#2877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
MaximumSubArraySum#2877
Uh oh!
There was an error while loading.Please reload this page.
Conversation
siriak left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, please add some tests as inhttps://github.com/TheAlgorithms/Java/pull/2871/files
| // Finding maximum subarray sum for the left subarray | ||
| int leftMax = -1000000000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please use Integer.MIN_VALUE
| } | ||
| // Find maximum subarray sum for the right subarray | ||
| int rightMax = -1000000000;//should be minimum value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
And here
| public class MaximumSubArraySum { | ||
| //Maximum Subarray Sum using Divide and Conquer algorithm | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| } | |
| } | |
| } | |
| } | |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
siddhant2002 commentedJan 19, 2022
Can I work under this issue? |
siriak commentedJan 19, 2022
@siddhant2002 yes, feel free to implement this |
22aam left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the code looks good to me
siddhant2002 commentedFeb 10, 2022
@siriak please check the pr |
siriak commentedFeb 10, 2022
@siddhant2002 which one? I've already reviewed this one |
siddhant2002 commentedFeb 11, 2022
@siriak please check the updated pr |
siriak commentedFeb 12, 2022
Superseded by#2913 |
Uh oh!
There was an error while loading.Please reload this page.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.