Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added Node generic classes#2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
siriak merged 6 commits intoTheAlgorithms:masterfromaitorfi:addGenericNodeClasses
Nov 8, 2021
Merged

Added Node generic classes#2782

siriak merged 6 commits intoTheAlgorithms:masterfromaitorfi:addGenericNodeClasses
Nov 8, 2021

Conversation

aitorfi
Copy link
Contributor

@aitorfiaitorfi commentedOct 30, 2021•
edited
Loading

Describe your change:

Added Node generic classes to be used directly or as superclasses for new implementations in order to avoid code repetition.

References

Related to issue#2774

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All functions and variable names follow Java naming conventions.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@aitorfiaitorfi marked this pull request as ready for reviewNovember 4, 2021 17:42
@aitorfiaitorfi changed the titleCloses #2774 Added Node generic classesAdded Node generic classesNov 4, 2021
Copy link
Member

@siriaksiriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@siriaksiriak merged commit7f3eb1b intoTheAlgorithms:masterNov 8, 2021
@aitorfiaitorfi deleted the addGenericNodeClasses branchSeptember 23, 2022 13:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@siriaksiriaksiriak approved these changes

@yanglbmeyanglbmeAwaiting requested review from yanglbmeyanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aitorfi@siriak
[8]ページ先頭
©2009-2025 Movatter.jp