Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

RGB-HSV conversion#2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@algobytewise
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@algobytewise
Copy link
ContributorAuthor

For the failed prettier-check, see#2149

Copy link
Member

@yanglbmeyanglbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please addpackage Conversions; to the file

@algobytewise
Copy link
ContributorAuthor

I've added the line. Thanks for having a look.

Copy link
Member

@ayaankhan98ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@ayaankhan98ayaankhan98 merged commitb95ba6c intoTheAlgorithms:masterApr 24, 2021
@ayaankhan98ayaankhan98 linked an issueApr 24, 2021 that may beclosed by this pull request
@algobytewisealgobytewise deleted the HSV-RGB-conversion branchApril 26, 2021 07:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@yanglbmeyanglbmeyanglbme requested changes

+1 more reviewer

@ayaankhan98ayaankhan98ayaankhan98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Waiting for reviews of contributions

3 participants

@algobytewise@yanglbme@ayaankhan98
[8]ページ先頭
©2009-2025 Movatter.jp