Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Euler method#2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@algobytewise
Copy link
Contributor

@algobytewisealgobytewise commentedMar 9, 2021•
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message containsFixes: #{$ISSUE_NO}.

@algobytewise
Copy link
ContributorAuthor

I was able to fix the error thrown by the code-formatter-check but I can't get it to pass the prettier-check. Could someone help me out?

Copy link
Member

@ayaankhan98ayaankhan98 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your contribution, please update the documentation according to Java docs standard.

refer to the documentation of thisfile in case you need any help regarding documentation.

also add tests

@algobytewise
Copy link
ContributorAuthor

Thanks for the feedback. I've reformatted the documentation and I've implemented tests to validate that the numerical arguments are in range.

@danielUTM
Copy link

danielUTM commentedMar 15, 2021•
edited
Loading

I just created another pull request for a separate addition that kept failing on the "Prettier / prettier" check with the same error message you are getting. I fixed the issue by changing branch I was comitting from to be called master and it fixed it, hope this helps you.

@algobytewisealgobytewise mentioned this pull requestMar 16, 2021
12 tasks
@algobytewise
Copy link
ContributorAuthor

Thank you for this insight! I've tried it and it also solved the problem for me, see#2148 . I'll close this pull request & open an issue.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@ayaankhan98ayaankhan98ayaankhan98 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@algobytewise@danielUTM@ayaankhan98
[8]ページ先頭
©2009-2025 Movatter.jp