Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Tim sort Algorithm | #2003#2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ayaankhan98 merged 23 commits intoTheAlgorithms:masterfromhemanth-kotagiri:tim_sort
Apr 23, 2021

Conversation

@hemanth-kotagiri
Copy link
Contributor

  • Add an algorithm?

References

Tim Sort Algorithm Wikipedia

  • I have readCONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.

@hemanth-kotagirihemanth-kotagiri changed the titleTim sort AlgorithmTim sort Algorithm | #2003Feb 21, 2021
Copy link
Member

@ayaankhan98ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please update the documentation according to Java docs standard.

@hemanth-kotagiri
Copy link
ContributorAuthor

Hey there,@ayaankhan98 . Got it. I will be on it. I've been a bit busy!

@hemanth-kotagiri
Copy link
ContributorAuthor

Hello,@ayaankhan98. Could you please review it now. I might have missed something! Lemme know!

Copy link
Member

@ayaankhan98ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please add a test function to verify the implementation

hemanth-kotagiri reacted with thumbs up emoji
hemanth-kotagiriand others added8 commitsMarch 10, 2021 10:55
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@stale
Copy link

stalebot commentedApr 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stalestalebot added the stale labelApr 18, 2021
@stalestalebot removed the stale labelApr 21, 2021
@hemanth-kotagiri
Copy link
ContributorAuthor

Would you give this a review@ayaankhan98

Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri
Copy link
ContributorAuthor

I appreciate your patience all the way along. Thanks. Is there anything else?@ayaankhan98 .

hemanth-kotagiriand others added3 commitsApril 23, 2021 22:30
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
Co-authored-by: Ayaan Khan <ayaankhan98@gmail.com>
@hemanth-kotagiri
Copy link
ContributorAuthor

Everything LGTM. Any other suggestions@ayaankhan98?

Copy link
Member

@ayaankhan98ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rest of the code is fine. Prettier and code formatter errors are due to broken CI

hemanth-kotagiri reacted with thumbs up emoji
@ayaankhan98ayaankhan98 merged commit66adafb intoTheAlgorithms:masterApr 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@ayaankhan98ayaankhan98ayaankhan98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hemanth-kotagiri@ayaankhan98
[8]ページ先頭
©2009-2025 Movatter.jp