- Notifications
You must be signed in to change notification settings - Fork20.7k
ReverseWord & ReverseWordsTest#2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
| class ReveresWordsTest extends ReverseWords { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not proper way to write tests.
If you don't know how a test is to be written, please checkDecimalToAnyBaseTestjava.
As you can see, it does not extend its source class. Instead it initializes its object with help of constructor.
Please do needful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I removed the import line and inheritance fromReverseWordsTest and initialized an object ofReverseWords in it.
| * @param s the string to convert | ||
| * @return the {@code String}, converted to a string with reveresed words. | ||
| */ | ||
| public static String isReverseWords(String s) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Method name is kind of not in sync with what it does, i.e.
publicstaticStringisReverseWords(Strings) {...}// Suggests that this will return boolean value.publicstaticStringreturnReverseWords(Strings) {...}// Suggests that this will return reversed string value.
NOTE : This is just an observation or suggestion.
loveshdongreNov 14, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I renamedisReverseWords toreturnReverseWords
Uh oh!
There was an error while loading.Please reload this page.
JackZeled0n commentedJan 3, 2021
I don't understand how you use the assertEquals. At the moment when I run the test java throw an exception because in your method return a string and then you compare with a boolean |
Uh oh!
There was an error while loading.Please reload this page.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.