NotificationsYou must be signed in to change notification settings
Fork20.7k
Star64.2k

Fixed code smells after running sonarqube on the project#1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

realDuYuanChao merged 4 commits intoTheAlgorithms:Developmentfromabhijaykumar:Development

Aug 25, 2020

Merged

Fixed code smells after running sonarqube on the project#1429

realDuYuanChao merged 4 commits intoTheAlgorithms:Developmentfromabhijaykumar:Development

Aug 25, 2020

Conversation

Copy link

Contributor

abhijaykumar commentedAug 21, 2020

Multiple code smells were found bySonarQube on the project. Some of them were violations of the below rules:

Local variable names in java must be with the default regular expression ^[a-z][a-zA-Z0-9]*$RSPEC-117
The diamond operator ("<>") should be used when the type of the maps are already definedRSPEC-2293
Package names being camel cased is a code smell, all package names must be lowercase
String literals should not be duplicatedRSPEC-1192
Generic types shouldn't be used raw (without type parameters) in variable declarations or return values. Doing so bypasses generic type checking, and defers the catch of unsafe code to runtime.RSPEC-3740
The dangling else problem appears when nested if/else statements are written without curly braces. In this case, else is associated with the nearest if but that is not always obvious and sometimes the indentation can also be misleading.RSPEC-5261

Here is the overall SonarQube report for the repo (Development) branch post the fixes.

This pull request brings down the code smells from 188 to 177.

abhijaykumar added4 commits

August 21, 2020 15:00

Removed code smells and followed naming convention

7fbf8f2

- Local variable names in java must be with the  default regular expression ^[a-z][a-zA-Z0-9]*$https://rules.sonarsource.com/java/tag/convention/RSPEC-117- The diamond operator ("<>") should be used when the type of the maps are already definedhttps://rules.sonarsource.com/java/RSPEC-2293- Package names being camel cased is a code smell

Added constant for string literal - code smell

57c1967

String literals should not be duplicatedhttps://rules.sonarsource.com/java/RSPEC-1192

Removing unused generic variable - code smell

6aecb37

Corrected code smells with raw type and dangling else block

2d797fb

-Generic types shouldn't be used raw (without type parameters) in variable declarations or return values. Doing so bypasses generic type checking, and defers the catch of unsafe code to runtime.https://rules.sonarsource.com/java/RSPEC-3740- The dangling else problem appears when nested if/else statements are written without curly braces. In this case, else is associated with the nearest if but that is not always obvious and sometimes the indentation can also be misleading.https://rules.sonarsource.com/java/tag/confusing/RSPEC-5261