- Notifications
You must be signed in to change notification settings - Fork20.7k
Add hexadecimal to binary and hexadecimal to decimal conversions#1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
MohamedBechir left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am sorry the first commit is hexadecimal to decimal conversion and the second one is hexadecimal to binary conversion ( the second commit message is false)
Sorry again
| package com.conversions; | ||
| public class HexadecimalToBinary { | ||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Your code fails in case of floating point conversion, 'ABC.BC' try doing it for real values also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good work but you missed out in the 2nd file.
MohamedBechir commentedMay 25, 2020
@deadshotsb Okay, thank you for your feedback I will fix it now. |
MohamedBechir commentedMay 25, 2020
@deadshotsb I have just fixed the requested changes can you check it and give me your feedback? |
| package com.conversions; | ||
| public class HexadecimalToBinary { | ||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good work but you missed out in the 2nd file.
| * @return decimal number | ||
| */ | ||
| public String hexToDecimal(String hexaStr) { | ||
| String hexaNumbers = "0123456789ABCDEF"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Your code fails in case of "AB.CD"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because from the point you must multiply for 1/16, the potency start to be negative
MohamedBechirMay 26, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nippur101
Yes, that's what I did, thank you
MohamedBechir commentedMay 25, 2020
@deadshotsb you are right sir, I'll do it now! Sorry |
deadshotsb commentedMay 25, 2020
@MohamedBechir We are all developers no sir and boss please |
MohamedBechir commentedMay 25, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@deadshotsb can you explain more what I am supposed to do? A.B => 10.11 or A.B => 10.6875? thank you |
deadshotsb commentedMay 25, 2020
A.B = 16^(0)*(10) + 16^(-1) * (11) |
MohamedBechir commentedMay 25, 2020
@deadshotsb I just fixed it, take a look. Thank you again |
Uh oh!
There was an error while loading.Please reload this page.
I have noticed that some conversions are missing, so I started by adding the hexadecimal to decimal and the hexadecimal to binary ones, if you approve it I can work on the other ones.
My code converts a hexadecimal number to a decimal one.
NB: I am new to the software engineering community. I did my best and if anything is wrong with my code I can change it anytime, I am eager to learn more.