Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

perf: 1.c faster implementation of the leetcode TwoSum problem#902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
straight-into-the-wall wants to merge20 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromstraight-into-the-wall:1c

Conversation

@straight-into-the-wall
Copy link
Contributor

@straight-into-the-wallstraight-into-the-wall commentedOct 25, 2021•
edited by gitpod-iobot
Loading

Description of Change

A faster and more documented solution of the TwoSum problem on leetcode.

seeTwoSum problem on leetcode

Old SubmissionDetail (pdf)

New SubmissionDetail (pdf)

References

Hacktoberfest issue

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semanticcommit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: faster and more documented solution of the leetcode TwoSum problem

@straight-into-the-wall
Copy link
ContributorAuthor

I'm expecting this to fail until the#898 will not be solved. For this I proposed two alternative solution in#900 and#901.

@Panquesito7Panquesito7 added the enhancementNew feature or request labelOct 25, 2021
@Panquesito7
Copy link
Member

Let's wait until#901 is merged. Feel free to ping me in case I forgot about this PR. 🙂

straight-into-the-wall reacted with hooray emoji

@straight-into-the-wall
Copy link
ContributorAuthor

Let's wait until#901 is merged. Feel free to ping me in case I forgot about this PR. slightly_smiling_face

ping.

@straight-into-the-wall
Copy link
ContributorAuthor

@Panquesito7 ping! This PR is ready too.

Panquesito7 and Screen-sLaYeR reacted with thumbs up emoji

Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Got this error while trying to compile.

image

Could you please fix the error? Let us know if you need any help. 🙂

@straight-into-the-wall
Copy link
ContributorAuthor

Hi@Panquesito7. Thanks for your time.

This should fix ... if I remember well as it didn't reproduce on my env.
Knowing what compilation parameters are used to check will help.

Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀 Thank you for your contribution! 😄👍

straight-into-the-wall reacted with thumbs up emoji
@Panquesito7Panquesito7 added the approvedApproved; waiting for merge labelDec 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Panquesito7Panquesito7Panquesito7 approved these changes

@aminoxixaminoxixAwaiting requested review from aminoxix

@ayaankhan98ayaankhan98Awaiting requested review from ayaankhan98

@mishraabhinnmishraabhinnAwaiting requested review from mishraabhinn

Assignees

No one assigned

Labels

approvedApproved; waiting for mergeenhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@straight-into-the-wall@Panquesito7
[8]ページ先頭
©2009-2025 Movatter.jp