Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update stack_using_linked_lists.c#620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Shwetik wants to merge9 commits intoTheAlgorithms:master
base:master
Choose a base branch
Loading
fromShwetik:patch-3

Conversation

@Shwetik
Copy link
Contributor

@ShwetikShwetik commentedSep 30, 2020
edited by gitpod-iobot
Loading

Description of Change

Added comments and time complexities.

  • Relevant documentation/comments is changed or added

Added comments and time complexities.
@Panquesito7Panquesito7 added the enhancementNew feature or request labelSep 30, 2020
Copy link
ContributorAuthor

@ShwetikShwetik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes made.


voidpush(structnode*p)
/**
* push function will add a new node at the head of the list, time complexity O(1).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Missing parameter documentation.
Same in other parts of the code.

Copy link
ContributorAuthor

@ShwetikShwetik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes made.

intitem;
structnode*temp;
temp= (structnode*)malloc(sizeof(structnode));
temp= (structnode*)malloc(sizeof(structnode));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please remove this empty whitespace.
Same in other parts of the code.

Suggested change
temp= (structnode*)malloc(sizeof(structnode));
temp= (structnode*)malloc(sizeof(structnode));

Copy link
ContributorAuthor

@ShwetikShwetik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Whitespaces removed.

Panquesito7
Panquesito7 previously approved these changesSep 30, 2020
Copy link
Member

@Panquesito7Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, good work. 👍 😄

Shwetik reacted with laugh emoji
@Panquesito7Panquesito7 added Admin views requestedRequesting opinions from Maintainers and Admins of the repo. approvedApproved; waiting for merge labelsSep 30, 2020
Shwetikand others added3 commitsOctober 1, 2020 05:19
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@kvedala
Copy link
Collaborator

#619 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Panquesito7Panquesito7Panquesito7 left review comments

@kvedalakvedalaAwaiting requested review from kvedala

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Admin views requestedRequesting opinions from Maintainers and Admins of the repo.approvedApproved; waiting for mergeenhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shwetik@kvedala@Panquesito7

[8]ページ先頭

©2009-2025 Movatter.jp