Added description of change
Added file name matchesFile name guidelines
Added tests and example, test must pass
Relevant documentation/comments is changed or added
PR title follows semanticcommit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:
A Basic Ring Buffer Implementation In C, in ringbuffer directory added to C/data_structures/, added suggested improvements

Ring Buffer/Circular Queue implementation added

c4bb12a

Speedster3030 requested review fromPanquesito7,tjgurwara99 andalexpantyukhin ascode owners

September 13, 2025 13:08

richvigorito reviewed

Sep 13, 2025

View reviewed changes

Copy link

richvigorito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for sharing this implementation! 🎉

I’ll admit this PR sent me back to refresh circular queue algorithms (I revisitedGeeksforGeeks
andTutorialsPoint
). After doing that, here are my thoughts:

The API is clear and works correctly.
The head/tail indexing works, but it’s a bit unconventional (decrementing instead of incrementing). A (x + 1) % max style is more common and may be easier to follow.
front() is great, but you might also consider adding a rear() function for API completeness.
Minor style: define macro definitions so return values are easier to digest when reading.

data_structures/ringbuffer.c Outdated

		{
		if(rb->count==rb->max)
		{
		return -1;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

might consider macro definitions. Would make the return values more for readability

#define RB_OK 0;
#define RB_FULL -1;
#define RB_EMPTY -2;

data_structures/ringbuffer.c Outdated

Comment on lines 49 to 54

		rb->arr[rb->tail]=n;
		rb->tail--;
		if(rb->tail==-1)
		{
		rb->tail=rb->max-1;
		}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider more conventional style for circular queues:

Suggested change

	rb->arr[rb->tail]=n;
	rb->tail--;
	if(rb->tail==-1)
	{
	rb->tail=rb->max-1;
	}
	rb->arr[rb->tail]=n;
	rb->tail= (rb->tail+1) %rb->max;

data_structures/ringbuffer.c Outdated

Comment on lines 67 to 74

		int t=rb->arr[rb->head];
		rb->arr[rb->head]=0;
		rb->head--;
		rb->count--;
		if(rb->head==-1)
		{
		rb->head=rb->max-1;
		}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Consider more conventional style for circular queues:

Suggested change

	intt=rb->arr[rb->head];
	rb->arr[rb->head]=0;
	rb->head--;
	rb->count--;
	if(rb->head==-1)
	{
	rb->head=rb->max-1;
	}
	*result=rb->arr[rb->head];
	rb->head= (rb->head+1) %rb->max;

data_structures/ringbuffer.c

		*result=rb->arr[rb->head];
		return 0;
		}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You already provide a front() function, but no equivalent rear() function. Since the buffer tracks both ends, it would be useful (and consistent withCircular Queue implementations) to add a rear() to peek at the last enqueued element.

Suggested change