Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

New feature in c++ project cgpa#22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dawitbeza wants to merge2 commits intoThe-Young-Programmer:main
base:main
Choose a base branch
Loading
fromdawitbeza:newFeature

Conversation

dawitbeza
Copy link

I have contributed to the CGPA Calculator C++ project by addressing several issues and making improvements.

Firstly, I fixed a bug related to the use of variables for array initialization, such as int name[q]. This caused the program to fail, as array sizes must be constant expressions known at compile-time. To resolve this, I replaced these statically sized arrays with dynamically sized arrays using vectors.

Secondly, I refactored the code by replacing all goto statements with while loops. The use of goto is generally discouraged in modern programming due to its impact on readability and maintainability.

Finally, and most importantly, I added a new InputValidation function. This function ensures that user inputs are validated based on specified upper and lower bounds as well as the correct data type. The program will now continue prompting the user until a valid input is entered.

@Samuel-de-OliveiraSamuel-de-Oliveira added bugSomething isn't working need to be testedNeed a test after merge labelsOct 18, 2024
@Samuel-de-Oliveira
Copy link
Collaborator

Hello Dawit, the@The-Young-Programmer is about 1 year out of Github, but him gived me access to this repository, anyway i can't accept this pull request without his permission, so let's wait for his response. 🦖

P. S. your fix looks good by the way

@dawitbeza
Copy link
Author

dawitbeza commentedOct 19, 2024
edited
Loading

Thank you so much! I truly feel like a professional software engineer now, and I appreciate your help!

Samuel-de-Oliveira and eeee88 reacted with rocket emoji

@The-Young-Programer

@dawitbeza
Can you implement this changes on my NEW Account
https://github.com/The-Young-Programer/C-CPP-Programming

I have contributed to the CGPA Calculator C++ project by addressing several issues and making improvements.

Firstly, I fixed a bug related to the use of variables for array initialization, such as int name[q]. This caused the program to fail, as array sizes must be constant expressions known at compile-time. To resolve this, I replaced these statically sized arrays with dynamically sized arrays using vectors.

Secondly, I refactored the code by replacing all goto statements with while loops. The use of goto is generally discouraged in modern programming due to its impact on readability and maintainability.

Finally, and most importantly, I added a new InputValidation function. This function ensures that user inputs are validated based on specified upper and lower bounds as well as the correct data type. The program will now continue prompting the user until a valid input is entered.

@dawitbeza
Can you implement this changes on my NEW Account
https://github.com/The-Young-Programer/C-CPP-Programming

@The-Young-Programer

Hello Dawit, the@The-Young-Programmer is about 1 year out of Github, but him gived me access to this repository, anyway i can't accept this pull request without his permission, so let's wait for his response. 🦖

P. S. your fix looks good by the way

@Samuel-de-Oliveira
Thanks so much for standing by me
This is my NEW Account
https://github.com/The-Young-Programer/C-CPP-Programming

I forgot my two factor authentication in my old account 🥲

Samuel-de-Oliveira and eeee88 reacted with confused emoji

@eeee88
Copy link

/*

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugSomething isn't workingneed to be testedNeed a test after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@dawitbeza@Samuel-de-Oliveira@The-Young-Programer@eeee88

[8]ページ先頭

©2009-2025 Movatter.jp