Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix table.getIsSomeRowsSelected when filtered out rows are selected#6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kahopfer wants to merge3 commits intoTanStack:main
base:main
Choose a base branch
Loading
fromkahopfer:fix-table-get-is-some-rows-selected

Conversation

@kahopfer
Copy link

@kahopferkahopfer commentedAug 20, 2025•
edited by coderabbitaibot
Loading

This pull request is for fixing an issue where table.getIsSomeRowsSelected occasionally returns an incorrect value when filtered out rows are selected.

Fixes#6079

Summary by CodeRabbit

  • Bug Fixes

    • Row selection status now reflects only visible (filtered) rows.
    • The header checkbox shows indeterminate state only when some visible rows are selected and not all.
    • “Select all” and partial selection behaviors align with the current filter view.

  • Chores

    • No changes to public APIs; behavior improved without altering external interfaces.

OriginalEXE and chlee1001 reacted with heart emoji
@coderabbitai
Copy link

coderabbitaibot commentedAug 20, 2025•
edited
Loading

Walkthrough

Refactors table.getIsSomeRowsSelected() to base its indeterminate-state calculation on selected rows within the current filtered (visible) rows instead of the total selection across all rows.

Changes

Cohort / File(s)Summary
Row selection visibility logic
packages/table-core/src/features/RowSelection.ts		getIsSomeRowsSelected() now derives visibleRows from table.getFilteredRowModel().flatRows, counts selectedVisibleRows via row.getIsSelected(), and returns true only when some but not all visible rows are selected.

Sequence Diagram(s)

sequenceDiagram  autonumber  actor User  participant Table  participant FilteredRows as Filtered Row Model  participant HeaderCheckbox as Header Checkbox  User->>Table: Apply filters / select rows  Table->>FilteredRows: getFilteredRowModel().flatRows  Table->>Table: selectedVisible = visibleRows.filter(row.getIsSelected())  alt Indeterminate condition    Table->>HeaderCheckbox: some(selectedVisible) && !all(selectedVisible)    note right of HeaderCheckbox: Checkbox state = indeterminate  else None selected    Table->>HeaderCheckbox: 0 selected    note right of HeaderCheckbox: Checkbox unchecked  else All selected    Table->>HeaderCheckbox: all visible selected    note right of HeaderCheckbox: Checkbox checked  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

ObjectiveAddressedExplanation
Fix getIsSomeRowsSelected to consider only visible (filtered) rows for indeterminate state (#6079)✅
Ensure header checkbox reflects indeterminate when some, not all, visible rows are selected (#6079)✅

Assessment against linked issues: Out-of-scope changes

None found.

Possibly related issues

Poem

A whisk of code, a hop, a fix—
I sniffed the rows through filter’s mix.
Now only what you see, I count,
Indeterminate joys amount.
Checkbox twitches, carrots cheer,
Selected truths are crystal-clear. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from theIntegrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type@coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a.coderabbit.yaml file to the root of your repository.
  • Please see theconfiguration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit ourStatus Page to check the current availability of CodeRabbit.
  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

Copy link

@coderabbitaicoderabbitaibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between9c62cf2 and756483a.

📒 Files selected for processing (1)
  • packages/table-core/src/features/RowSelection.ts (1 hunks)

Comment on lines +434 to 439
constvisibleRows=table.getFilteredRowModel().flatRows
constselectedVisibleRows=visibleRows.filter(row=>row.getIsSelected())
return(
totalSelected>0&&
totalSelected<table.getFilteredRowModel().flatRows.length
selectedVisibleRows.length>0&&
selectedVisibleRows.length<visibleRows.length
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🛠️ Refactor suggestion

Good fix; also exclude non-selectable rows and account for partial (subrow) selection to avoid new inconsistencies.

This change correctly scopes the calculation to the filtered (visible) set, fixing#6079. However:

  • It counts against all visible rows, including those that cannot be selected. This can incorrectly set the header to indeterminate when all selectable rows are selected but some visible rows are not selectable.
  • It ignores rows that are “partially selected” via subrows (getIsSomeSelected), which page-level logic already handles.

Align this with getIsSomePageRowsSelected by considering only selectable rows and including partial selection. Suggested diff:

-    const visibleRows = table.getFilteredRowModel().flatRows-    const selectedVisibleRows = visibleRows.filter(row => row.getIsSelected())-    return (-      selectedVisibleRows.length > 0 &&-      selectedVisibleRows.length < visibleRows.length-    )+    const visibleSelectableRows = table+      .getFilteredRowModel()+      .flatRows.filter(row => row.getCanSelect())+    if (!visibleSelectableRows.length) return false+    if (table.getIsAllRowsSelected()) return false+    return visibleSelectableRows.some(+      row => row.getIsSelected() || row.getIsSomeSelected()+    )

This keeps behavior consistent with page-level helpers and prevents regressions when non-selectable rows are present in the filtered view.

I can add unit tests covering:

  • Selected rows filtered out vs. visible subset.
  • Presence of non-selectable rows alongside selectable ones.
  • Partial (subrow) selection affecting the indeterminate state.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
constvisibleRows=table.getFilteredRowModel().flatRows
constselectedVisibleRows=visibleRows.filter(row=>row.getIsSelected())
return(
totalSelected>0&&
totalSelected<table.getFilteredRowModel().flatRows.length
selectedVisibleRows.length>0&&
selectedVisibleRows.length<visibleRows.length
)
constvisibleSelectableRows=table
.getFilteredRowModel()
.flatRows.filter(row=>row.getCanSelect())
if(!visibleSelectableRows.length)returnfalse
if(table.getIsAllRowsSelected())returnfalse
returnvisibleSelectableRows.some(
row=>row.getIsSelected()||row.getIsSomeSelected()
)
🤖 Prompt for AI Agents
In packages/table-core/src/features/RowSelection.ts around lines 434 to 439, thecurrent visible-row indeterminate logic counts all visible rows and ignorespartial/subrow selection, which can mark the header indeterminate when onlynon-selectable rows remain or miss when subrows are partially selected; updatethe calculation to first filter visibleRows to only those withrow.getCanSelect(), then compute selectedVisibleRows as rows whererow.getIsSelected() OR row.getIsSomeSelected(), and finally return true whenselectedVisibleRows.length > 0 and selectedVisibleRows.length <selectableVisibleRows.length so the indeterminate state matchesgetIsSomePageRowsSelected and excludes non-selectable rows.

@changeset-bot
Copy link

⚠️ No Changeset found

Latest commit:cbc69c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TablegetIsSomeRowsSelected() does not consistently return correct value when column filter is applied

1 participant

@kahopfer
[8]ページ先頭
©2009-2025 Movatter.jp