- Notifications
You must be signed in to change notification settings - Fork3.4k
#964 solution#965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:feature/initJsonString
Are you sure you want to change the base?
#964 solution#965
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| func testURL(){ | ||
| letjson=JSON("http://github.com") | ||
| XCTAssertEqual(json.URL!,URL(string:"http://github.com")!) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| returnFoundation.URL(string: encodedString_) | ||
| }else{ | ||
| returnnil | ||
| }else{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration. (statement_position)
Uh oh!
There was an error while loading.Please reload this page.
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:
What behavior was changed?
compatible with url keyword '#'
What code was refactored / updated to support this change?
url encode characterSet have been changed
update the url test in StringTests.swift
What issues are related to this PR? Or why was this change introduced?
issuejson.url method returned url encoded the '#' #964
Checklist - While not every PR needs it, new features should consider this list:
yes
no
no
no