- Notifications
You must be signed in to change notification settings - Fork3.4k
Correct fix for #1041 and #1038#1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
aesilevich wants to merge1 commit intoSwiftyJSON:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is required for compatibility with Swift Foundationon Linux and Android platforms. On those platforms, NSNumberalready implements comparison operators, which causes conflicts.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes compatibility issues with the Swift toolchain for Linux described in#1041 and#1038, but does so in a safer and more reliable way, as suggested in the latest comments on PR#1083.
The root cause of these issues is that the open-source version of the Foundation library, SwiftFoundation, implements its own comparison operators for the NSNumber type. This causes ambiguity with the comparison operators implemented in SwiftyJSON. To avoid this, we replace SwiftyJSON’s comparison operators with simple functions and use them for all platforms, without conditional compilation or relying on different comparison operators for each platform. This approach is safer because it avoids depending on SwiftFoundation’s operator implementations.
- Does this have tests?
Existing tests already cover the changes in this PR.
- Does this have documentation?
No additional documentation is required.
- Does this break the public API (Requires major version bump)?
No, it does not break the public API.
- Is this a new feature (Requires minor version bump)?
No, this is not a new feature and does not require a minor version bump.