Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork927
Comments
fix FontFeature initial, ListStyleType initial#1379
fix FontFeature initial, ListStyleType initial#1379phamconganh wants to merge 1 commit intoSub6Resources:masterfrom
Conversation
| try { | ||
| fontFeatures.add(FontFeature(exp.text, | ||
| nextExp.text == "on" || nextExp.text == "1" ? 1 : 0)); | ||
| } catch (_) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you describe a little bit about why we're doing this and ignoring the caught error? Is there a GitHub issue you can reference to describe what the justification for this PR is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it was a long time ago so i don't remember clearly. there was a case that caused the init font reading to fail, i added it so it wouldn't affect the rendering
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #1379 +/- ##======================================= Coverage 64.08% 64.08% ======================================= Files 39 39 Lines 3032 3032 ======================================= Hits 1943 1943 Misses 1089 1089 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.