- Notifications
You must be signed in to change notification settings - Fork117
Added Prettier to ESLint / VSCode#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Added instructions in package.md and eslintrc.js to change.
This simplifies cross platform dev
Contributor
liborpansky commentedJan 6, 2021
Great! I'm a bug fan of Prettier as well and prefer it over ESLint. Definitely better configuration than the PR from yesterday. Thanks a lot for your time, this PR and especially the one with debugging experience is a great improvement for the template! |
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added instructions in package.md and eslintrc.js to change.
I didn't know if you would find this useful; I like Prettier and wanted to integrate it. I tweaked a couple of rules and reformatted files so with this PR, the code passes both ESLint + Standard and Prettier linting.
If you don't want this, no harm, just wanted to offer it.