Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor file detection and scanning logic to fix commit file handling#101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dacoburn merged 2 commits intomainfromdoug/fix-commit-detected-files
Jul 23, 2025

Conversation

@dacoburn
Copy link
Collaborator

Root Cause

The files logic for detecting if there were changed manifest files had been broken over time. At this point it was completely decoupled and in most instances things didn't work correctly without--ignore-commit-files

Fix

  • Fix file argument parsing to handle list, string, and JSON formats more robustly
  • Clarify git repository detection and file selection logic with better separation of concerns
  • Add force_api_mode to handle cases where no supported manifest files are found
  • Replace ambiguous should_skip_scan logic with clearer file detection flow
  • Add create_full_scan_with_report_url method to Core for API-mode scanning
  • Improve logging messages and remove unused code (get_all_scores method)
  • Ensure consistent diff object initialization and ID handling
  • Automatically enable disable_blocking when no supported files are detected

Public Changelog

• Fixed file detection logic that was preventing proper scanning of changed manifest files
• Improved handling of different file input formats (list, string, JSON) for better reliability
• Enhanced automatic detection of git repository changes and manifest file filtering
• Fixed cases where scans would incorrectly skip when manifest files were present in commits

- Fix file argument parsing to handle list, string, and JSON formats more robustly- Clarify git repository detection and file selection logic with better separation of concerns- Add force_api_mode to handle cases where no supported manifest files are found- Replace ambiguous should_skip_scan logic with clearer file detection flow- Add create_full_scan_with_report_url method to Core for API-mode scanning- Improve logging messages and remove unused code (get_all_scores method)- Ensure consistent diff object initialization and ID handling- Automatically enable disable_blocking when no supported files are detected
@dacoburndacoburn added the Product ChangelogNew features for the public changelog labelJul 23, 2025
@dacoburndacoburn requested a review froma team as acode ownerJuly 23, 2025 00:10
@dacoburndacoburn requested review frombarslev andtmpvar and removed request fora teamJuly 23, 2025 00:10
@github-actions
Copy link

github-actionsbot commentedJul 23, 2025
edited
Loading

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.23.dev1

Docker image:socketdev/cli:pr-101

…r exhaustion- Add --save-submitted-files-list option to output JSON with list of scanned files, sizes, and metadata for debugging- Add --save-manifest-tar option to create tar.gz archive of all manifest files with original directory structure- Implement lazy file loading to prevent 'Too many open files' errors when scanning large numbers of manifest files- Add system resource utilities to check file descriptor limits and warn when approaching ulimit -n- Update .gitignore to exclude AI testing files and verification scripts- Update README with comprehensive documentation for new debugging features and examples
@dacoburndacoburn merged commit69ec6b9 intomainJul 23, 2025
6 checks passed
@dacoburndacoburn deleted the doug/fix-commit-detected-files branchJuly 23, 2025 04:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ahmadnassriahmadnassriahmadnassri left review comments

@philidemphilidemphilidem approved these changes

@tmpvartmpvarAwaiting requested review from tmpvartmpvar is a code owner automatically assigned from SocketDev/eng

@barslevbarslevAwaiting requested review from barslevbarslev is a code owner automatically assigned from SocketDev/eng

Assignees

No one assigned

Labels

Product ChangelogNew features for the public changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dacoburn@ahmadnassri@philidem

[8]ページ先頭

©2009-2025 Movatter.jp