Commitbfc8fae

committed

fix(smol): set GYP_MSVS_VERSION to bypass VS auto-detection

Gyp's auto-detection fails even with VS environment variables set.Setting GYP_MSVS_VERSION=2022 tells gyp to use VS 2022 directly.

1 parentd9a26cc commitbfc8faeCopy full SHA for bfc8fae

File tree

+11

-2

lines changed

+11

-2

lines changed

Lines changed: 11 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1452,11 +1452,20 @@ async function main() {`
`1452`	`1452`	`// propagate environment variables to subprocesses.`
`1453`	`1453`	`constexecOptions={`
`1454`	`1454`	`cwd:NODE_DIR,`
`1455`		`-env:process.env,`
	`1455`	`+env:WIN32`
	`1456`	`+ ?{`
	`1457`	`+ ...process.env,`
	`1458`	`+// Tell gyp to use VS 2022, bypassing auto-detection.`
	`1459`	`+// https://github.com/nodejs/node/blob/main/BUILDING.md#windows`
	`1460`	`+// https://github.com/nodejs/node/blob/main/tools/gyp/pylib/gyp/MSVSVersion.py`
	`1461`	`+GYP_MSVS_VERSION:'2022',`
	`1462`	`+}`
	`1463`	`+ :process.env,`
`1456`	`1464`	`shell:false,`
`1457`	`1465`	`}`
`1458`	`1466`	`if(WIN32){`
`1459`		-logger.log(`DEBUG: Passing env with${Object.keys(process.env).length} variables (shell: false)`)
	`1467`	+logger.log(`DEBUG: Passing env with${Object.keys(execOptions.env).length} variables (shell: false)`)
	`1468`	+logger.log(`DEBUG: GYP_MSVS_VERSION =${execOptions.env.GYP_MSVS_VERSION}`)
`1460`	`1469`	`}`
`1461`	`1470`
`1462`	`1471`	`awaitexec(configureCommand,configureArgs,execOptions)`

Comments

(0)