This repository was archived by the owner on Oct 20, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork133
Add support for WEBP images#149
Open
matthew-petrie wants to merge2 commits intoShopify:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add support for `.jpeg.webp` images in the `getSizedImageUrl` function.Shopify outputs images in WEBP, for example this real Shopify URL: `https://cdn.shopify.com/s/files/1/0896/0640/products/IMG_20190622_130045_clipped_rev_1.jpeg.webp?v=1582896583`
SpurIT commentedFeb 11, 2021 via email
Hello,I am out of the office till March 1. Please reach out to the Sales Manager that you are working with or to philip.p@spur-i-t.com if you have any questions. |
Author
matthew-petrie commentedFeb 11, 2021
I've signed the CLA but not sure how to re-run the check |
joshistoast commentedAug 19, 2022
Would love to boost our performance with webp images, but the lack of support and this dangling pr is frankly sad |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add support for
.jpeg.webp&.jpg.webpimages in thegetSizedImageUrlfunction.Shopify outputs images in WEBP format which need to be able to have sizes added, for example this real Shopify URL:
https://cdn.shopify.com/s/files/1/0896/0640/products/IMG_20190622_130045_clipped_rev_1.jpeg.webp?v=1582896583