- Notifications
You must be signed in to change notification settings - Fork94
add ListDag function declaration in store#61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
AHHH32 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
add
| GetTaskIns(taskInsstring) (*entity.TaskInstance,error) | ||
| GetDag(dagIdstring) (*entity.Dag,error) | ||
| GetDagInstance(dagInsIdstring) (*entity.DagInstance,error) | ||
| ListDag(input*ListDagInput) ([]*entity.Dag,error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
也得在MockStore 实现这个接口，不然之前的用例会失败
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
请问你说的之前的用例会失败是什么意思？因为我现在这么用的目前没发现，并且我这样可以正常获取到定义的dag。
store:=mod.GetStore()ifstore==nil {returnnil}dagDefine,err:=store.ListDag(nil)
我在使用获取全部定义的dag时，发现源码中已经有相关函数实现，但是没有在Store中进行声明，因此不能使用。这个修改是在Store中添加函数声明