Coverage remained the same at 97.494% when pulling3d6bf31 on karikera:patch-1 into62fd61e on SheetJS:master.

One of the comments in the original code was:

/* note: TS cannot export top-level indexer, hence default workaround */

I assume this was in an older version of typescript. Can you verify the new export works in older versions of TS? I think we need to test back to 2.2

@SheetJSDev

I compiledindex.d.ts without error in TS@2.2

So I had to add"strictFunctionTypes": true totypes/tsconfig.json. To test the type definitions,make tslint and it shows errors like

/tmp/js-codepage/types/codepage-test.ts:1:8ERROR: 1:8    expect                           TypeScript@next compile error: Module '"/tmp/js-codepage/types/index"' has no default export.

The offending test code was:

importcptablefrom'codepage';

This was fixed in the type definition using

exportdefaultcptable;

Is there a reason to preferexport = cptable overexport default?

@SheetJSDev
export default is not compiled tomodule.exports = cptable
export default cptable ismodule.exports['default'] = cptable

this module has errors on TS