Commit9556a84

committed

show pass subtask when task passes

Signed-off-by: shmck <shawn.j.mckay@gmail.com>

1 parentd3ff8f9 commit9556a84Copy full SHA for 9556a84

File tree

2 files changed

+16

-20

lines changed

src/services/testRunner
- index.ts
web-app/src/containers/Tutorial/components
- Step.tsx

2 files changed

+16

-20

lines changed

`‎src/services/testRunner/index.ts‎`

Lines changed: 15 additions & 19 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,14 +50,7 @@ const createTestRunner = (data: TT.Tutorial, callbacks: Callbacks) => {`
`50`	`50`	`return`
`51`	`51`	`}`
`52`	`52`
`53`		`-console.log('STEP')`
`54`		`-console.log(JSON.stringify(step))`
`55`		`-`
`56`		`-// flag as running`
`57`		`-// no need to flag subtasks as running`
`58`		`-if(!step.setup?.subtasks){`
`59`		`-callbacks.onRun(position)`
`60`		`-}`
	`53`	`+callbacks.onRun(position)`
`61`	`54`
`62`	`55`	`letresult:{stdout:string\|undefined;stderr:string\|undefined}`
`63`	`56`	`try{`
`@@ -98,16 +91,6 @@ const createTestRunner = (data: TT.Tutorial, callbacks: Callbacks) => {`
`98`	`91`
`99`	`92`	`consttap:ParserOutput=parser(stdout\|\|'')`
`100`	`93`
`101`		`-if(step.setup.subtasks){`
`102`		`-constsummary=parseSubtasks(tap.summary,position.stepId\|\|'')`
`103`		`-`
`104`		`-console.log('---subtask summary')`
`105`		`-console.log(summary)`
`106`		`-callbacks.onLoadSubtasks({ summary})`
`107`		`-// exit early`
`108`		`-return`
`109`		`-}`
`110`		`-`
`111`	`94`	`addOutput({channel:logChannelName,text:tap.logs.join('\n'),show:false})`
`112`	`95`
`113`	`96`	`if(stderr){`
`@@ -128,7 +111,18 @@ const createTestRunner = (data: TT.Tutorial, callbacks: Callbacks) => {`
`128`	`111`	`description:firstFail.details\|\|'Unknown error',`
`129`	`112`	`summary:tap.summary,`
`130`	`113`	`}`
`131`		`-callbacks.onFail(position,failSummary)`
	`114`	`+`
	`115`	`+if(step.setup.subtasks){`
	`116`	`+constsubtaskSummary=parseSubtasks(tap.summary,position.stepId\|\|'')`
	`117`	`+`
	`118`	`+callbacks.onFail(position,{`
	`119`	`+ ...failSummary,`
	`120`	`+summary:subtaskSummary,`
	`121`	`+})`
	`122`	`+}else{`
	`123`	`+callbacks.onFail(position,failSummary)`
	`124`	`+}`
	`125`	`+`
`132`	`126`	`constoutput=formatFailOutput(tap)`
`133`	`127`	`addOutput({channel:failChannelName,text:output,show:true})`
`134`	`128`	`return`
`@@ -142,13 +136,15 @@ const createTestRunner = (data: TT.Tutorial, callbacks: Callbacks) => {`
`142`	`136`
`143`	`137`	`// PASS`
`144`	`138`	`if(tap.ok){`
	`139`	`+console.log('running pass')`
`145`	`140`	`clearOutput(failChannelName)`
`146`	`141`
`147`	`142`	`callbacks.onSuccess(position)`
`148`	`143`
`149`	`144`	`if(onSuccess){`
`150`	`145`	`onSuccess()`
`151`	`146`	`}`
	`147`	`+5`
`152`	`148`	`}else{`
`153`	`149`	`// should never get here`
`154`	`150`	onError(newError(`Error with running test${JSON.stringify(position)}`))

`‎web-app/src/containers/Tutorial/components/Step.tsx‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ const Step = (props: Props) => {`
`67`	`67`	`<ulcss={styles.subtasks}>`
`68`	`68`	`{props.subtasks.map((subtask)=>(`
`69`	`69`	`<likey={subtask.name}css={styles.subtask}>`
`70`		`-<TestStatusIconsize="xs"checked={subtask.pass}/>`
	`70`	`+<TestStatusIconsize="xs"checked={props.status==='COMPLETE'\|\|subtask.pass}/>`
`71`	`71`
`72`	`72`	`<spanstyle={{marginLeft:'0.5rem'}}>{subtask.name}</span>`
`73`	`73`	`</li>`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9556a84

File tree

2 files changed

2 files changed

`‎src/services/testRunner/index.ts‎`

`‎web-app/src/containers/Tutorial/components/Step.tsx‎`

0 commit comments