Commitfb5b841

committed

Use mocha to check for global leaks

1 parentb4af5ba commitfb5b841Copy full SHA for fb5b841

File tree

-9

lines changed

-9

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@`
`33`	`33`	`"mocha":"^2.1.0"`
`34`	`34`	`},`
`35`	`35`	`"scripts": {`
`36`		`-"test":"node node_modules/mocha/bin/mocha -R spec",`
	`36`	`+"test":"mocha -R spec --check-leaks",`
`37`	`37`	`"coverage":"istanbul cover ./node_modules/mocha/bin/_mocha"`
`38`	`38`	`}`
`39`	`39`	`}`

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,14 +16,6 @@ describe("rewire", function () {`
`16`	`16`	`fs.renameSync(fakeNodeModules,path.resolve(__dirname,"testModules/node_modules"));`
`17`	`17`	`}`
`18`	`18`	`});`
`19`		`-it("should keep not leak globals",function(){`
`20`		`-// This test should run first, as the global space may be already polluted if`
`21`		`-// require("../") is run before this test.`
`22`		`-varoriginalGlobalKeys=Object.keys(global),`
`23`		`-rewire=require("../"),`
`24`		`-emptyModule=rewire("./testModules/emptyModule.js");`
`25`		`-expect(Object.keys(global)).to.eql(originalGlobalKeys);`
`26`		`-});`
`27`	`19`	`it("should pass all shared test cases",function(){`
`28`	`20`	`require("./testModules/sharedTestCases.js");`
`29`	`21`	`});`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -256,6 +256,9 @@ describe("rewire " + (typeof testEnv === "undefined"? "(node)": "(" + testEnv +`
`256`	`256`	`// setting implicit global vars will change them globally instead of locally.`
`257`	`257`	`// that's a shortcoming of the current implementation which can't be solved easily.`
`258`	`258`	`//expect(implicitGlobal).to.be.a("string");`
	`259`	`+`
	`260`	`+// Cleaning up...`
	`261`	`+deleteglobal.implicitGlobal;`
`259`	`262`	`});`
`260`	`263`
`261`	`264`	`it("should throw a TypeError if the path is not a string",function(){`

Comments

(0)