Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(types): Update SemanticShorthandCollection to support Typescript 4.8#4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
layershifter merged 1 commit intoSemantic-Org:masterfromtimduffin:master
Oct 19, 2022

Conversation

@timduffin
Copy link
Contributor

@timduffintimduffin commentedOct 17, 2022•
edited
Loading

typescript@4.8.4 build error

73 export type SemanticShorthandCollection<TProps> = SemanticShorthandItem<TProps>[]                                               ~~~~~~    This type parameter might need an `extends Record<string, any>` constraint.

For completeness, here is the breaking change in question
https://devblogs.microsoft.com/typescript/announcing-typescript-4-8-beta/#breaking-changes

@welcome
Copy link

welcomebot commentedOct 17, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Runyarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Runyarn test locally to catch errors. This ensures all components still behave as they should.
  • Runyarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@iamtomcat
Copy link

Nice wanted to sort this out as well.

timduffin reacted with thumbs up emoji

@timduffin
Copy link
ContributorAuthor

The powers that be need to updateVercel's node build version

Error: Node.js Version "12.x" is discontinued and must be upgraded. Please set Node.js Version to 16.x in your Project Settings to use Node.js 16.

@layershifter
Copy link
Member

The powers that be need to updateVercel's node build version

Error: Node.js Version "12.x" is discontinued and must be upgraded. Please set Node.js Version to 16.x in your Project Settings to use Node.js 16.

Done 👍
Will check the PR a bit later this week.

timduffin reacted with rocket emoji

@layershifterlayershifter changed the titlefix:(type-checking): typescript@4.8.4 Tprops errorfix(types): Update SemanticShorthandCollection to support Typescript 4.8Oct 19, 2022
@layershifter
Copy link
Member

@timduffin thank you 👍

timduffin reacted with heart emoji

@layershifterlayershifter merged commitc3cbcae intoSemantic-Org:masterOct 19, 2022
@welcome
Copy link

welcomebot commentedOct 19, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@quanganhtran
Copy link

Could we release this fix?

Grmiade and charliematters reacted with thumbs up emoji

@layershifter
Copy link
Member

@quanganhtran was released insemantic-ui-react@2.1.4.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@layershifterlayershifterlayershifter approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@timduffin@iamtomcat@layershifter@quanganhtran
[8]ページ先頭
©2009-2025 Movatter.jp