Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: make typings compatible with @types/react@18#4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
layershifter merged 2 commits intoSemantic-Org:masterfromLurk:master
Apr 19, 2022

Conversation

@Lurk
Copy link
Contributor

@LurkLurk commentedApr 18, 2022•
edited
Loading

fixes#4352

what changed

react typing package is updated to the latest version (18.0.5) (also added to package.resolutions because of react-helm)
Most of the work in typings was React.StatelessComponent to React.FC replacement

isaacaskew, SakisTsalk, casperOne, and y-yagi reacted with thumbs up emoji
@welcome
Copy link

welcomebot commentedApr 18, 2022

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Runyarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Runyarn test locally to catch errors. This ensures all components still behave as they should.
  • Runyarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-commenter
Copy link

codecov-commenter commentedApr 18, 2022•
edited
Loading

Codecov Report

Merging#4356 (34087fc) intomaster (24e47ca) willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master    #4356   +/-   ##=======================================  Coverage   99.75%   99.75%           =======================================  Files         180      180             Lines        3248     3248           =======================================  Hits         3240     3240             Misses          8        8

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update9dd0596...34087fc. Read thecomment docs.

Lurk pushed a commit to Lurk/barhamon that referenced this pull requestApr 18, 2022
- add an assertion to "test/typings"
@layershifterlayershifter changed the titlefixes #4352 (typecheck failed)fix: make typings compatible with @types/reactApr 19, 2022
@layershifterlayershifter changed the titlefix: make typings compatible with @types/reactfix: make typings compatible with @types/react@18Apr 19, 2022
Copy link
Member

@layershifterlayershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Lurk great job, and good for us that we declarechildren explicitly.

Lurk reacted with thumbs up emoji
@welcome
Copy link

welcomebot commentedApr 19, 2022

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@Lurk
Copy link
ContributorAuthor

@layershifter Yeah, if there were no explicit children already, the pull request would be much bigger 🙃

@ExeAy
Copy link

Is this planned to be released any time soon?

Adnan-Niloy, ComLock, hwennnn, BarneyLYO, and lekksi reacted with thumbs up emoji

@layershifter
Copy link
Member

Released insemantic-ui-react@2.1.3.

Lurk and danursin reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@layershifterlayershifterlayershifter approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type check with @types/react 18 failing

4 participants

@Lurk@codecov-commenter@ExeAy@layershifter
[8]ページ先頭
©2009-2025 Movatter.jp