Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow subsettingInitials insubset_tunables#3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
DhairyaLGandhi wants to merge1 commit intoSciML:master
base:master
Choose a base branch
Loading
fromDhairyaLGandhi:dg/set_init

Conversation

@DhairyaLGandhi
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular theSciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

cc@SebastianM-C can you check if this is sufficient for your use cases, and we can add a test then

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

We should make sure this gets appropriately tested in SciMLSensitivity too.

SebastianM-C reacted with thumbs up emoji

@SebastianM-C
Copy link
Member

yeah, it seems to work for me (on a simple example at least)

@SebastianM-C
Copy link
Member

Btw, I noticed thatsubset_tunables does not removeInitials. Does this affect the performance or it's not an issue?

@ChrisRackauckas
Copy link
Member

That will not effect the performance of adjoints much, but it will forward mode

@AayushSabharwal
Copy link
Member

Initials are not tunables. Why exactly do we need this?

@SebastianM-C
Copy link
Member

I'm not sure if we need this or not, I just noticed thatInitials show up intunable_parameters(sys).

@AayushSabharwal
Copy link
Member

Oh, that's a lie. I'm pretty sure when I added initials and theinitial_parameters = true keyword, I just did a find-replace of allparameters(sys) toparameters(sys; initial_parameters = true). This is probably a remnant of that.

@DhairyaLGandhi
Copy link
MemberAuthor

Does that mean this can be closed since it won't be actionable

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DhairyaLGandhi@ChrisRackauckas@SebastianM-C@AayushSabharwal
[8]ページ先頭
©2009-2025 Movatter.jp