Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32
fix: Serializing dictionary with ', ", . in key & #37#38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fixes issue where GetTopLevelAndSubKeys splits a key when serializing.Adds test to handle new cases.Does not test cases with mixed " and ' due to issue explained inSamboyCoding#57
coveralls commentedJan 14, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
IdeallyfixesSamboyCoding#37, but current implementation has some issues.Will elaborate on issues with this "fix" in a comment.
ITR13 commentedJan 14, 2024
Easiest way to understand the issue is the test StringTests.EscapedQuotesInAKeyAreValid: The parser is also unable to parse strings in the form "a.b".c or ""a.b"".c, which both are allowed in the toml specification.
|
Added test for redefining dotted key.Made InternalPutValue always have lineNumber since it's used by the parser.Deleted now unused exception.
The current exception thrown here already shows line-number.
I think rider had a field-day when getting to generate Designer.rsAdded tests for String Reader since Backtrack wasn't covered.Added test for Document.ToString()Added test for more places it's possible to reach the end of the file.Added test for different ways of writing numbers.
levicki commentedMar 15, 2024
This fix seems to be related to theissue I reported. Is there any ETA for it? |
Uh oh!
There was an error while loading.Please reload this page.
Fixes issue where GetTopLevelAndSubKeys splits a key when serializing.
Adds test to handle new cases.
Does not test cases with mixed " and ' due to issue explained in#37.