Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixing folder 550 delete action#47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamKirkland merged 2 commits intoSamKirkland:masterfromKonnng:fix/remove-dir
Aug 25, 2025

Conversation

@konnng-dev
Copy link
Contributor

This pull request improveserror handling when removing directories during FTP operations. In certain cases, the target directory may already be unavailable (e.g., deleted, renamed, or removed by a build process). Instead of throwing an exception, the process now logs awarning informing the user that the directory could not be removed or accessed.

This approach ensures that thestate file remains in sync and avoids breaking deployments that rely on theSamKirkland/FTP-Deploy-Action GitHub Action.

Summary of Changes

  • Improved Error Handling:
    • Replaces exceptions with warnings when directories cannot be removed.
  • Deployment Reliability:
    • Keeps the state file consistent even if some directories are missing.
    • Prevents deployments from failing due to non-critical directory removal issues.

@SamKirkland
Copy link
Owner

Thanks for the pull request!
Looks good & makes sense to me!

Copy link
Owner

@SamKirklandSamKirkland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One minor change.
Thanks a bunch for the PR!

@juliovedovatto
Copy link

juliovedovatto commentedAug 25, 2025
edited
Loading

Hi@SamKirkland

Thank you so much for the fast review. I addressed your comment and sent an update. Could you check again?

SamKirkland reacted with thumbs up emoji

@SamKirklandSamKirkland self-requested a reviewAugust 25, 2025 18:30
Copy link
Owner

@SamKirklandSamKirkland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great!

@SamKirklandSamKirkland merged commit8ab5e9e intoSamKirkland:masterAug 25, 2025
@SamKirkland
Copy link
Owner

I will need to release a new version of the NPM package & update the action as well

juliovedovatto reacted with thumbs up emojijuliovedovatto reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SamKirklandSamKirklandSamKirkland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@konnng-dev@SamKirkland@juliovedovatto

[8]ページ先頭

©2009-2025 Movatter.jp