- Notifications
You must be signed in to change notification settings - Fork55
Fixing folder 550 delete action#47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One minor change.
Thanks a bunch for the PR!
Uh oh!
There was an error while loading.Please reload this page.
juliovedovatto commentedAug 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you so much for the fast review. I addressed your comment and sent an update. Could you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great!
I will need to release a new version of the NPM package & update the action as well |
This pull request improveserror handling when removing directories during FTP operations. In certain cases, the target directory may already be unavailable (e.g., deleted, renamed, or removed by a build process). Instead of throwing an exception, the process now logs awarning informing the user that the directory could not be removed or accessed.
This approach ensures that thestate file remains in sync and avoids breaking deployments that rely on the
SamKirkland/FTP-Deploy-ActionGitHub Action.Summary of Changes