- Notifications
You must be signed in to change notification settings - Fork1.7k
Bugfix: Fix inconsistent VAD defaults in BatchedInferencePipeline#1409
Open
Purfview wants to merge 5 commits intoSYSTRAN:masterfrom
Open
Bugfix: Fix inconsistent VAD defaults in BatchedInferencePipeline#1409Purfview wants to merge 5 commits intoSYSTRAN:masterfrom
Purfview wants to merge 5 commits intoSYSTRAN:masterfrom
Conversation
Collaborator
MahmoudAshraf97 commentedJan 9, 2026
Sorry for the delayed review, overwhelmed at work right now and will do it as soon as I can |
ContributorAuthor
Purfview commentedJan 9, 2026
No worries at all, take your time, there's no rush. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inconsistent VAD defaults in BatchedInferencePipeline
Bug:
BatchedInferencePipeline applies inconsistent defaults for
min_silence_duration_ms.If
vad_parametersis not passed, the value defaults to160. When e.g. onlythresholdis passed, it defaults to2000.