Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.9k
Android examples#3613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
JonnyPtn wants to merge13 commits intoSFML:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Android examples#3613
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…lt android project guff
| # Executables on android are shared libraries loaded by the native activity | ||
| add_library(${target} SHARED${target_input}) | ||
| target_link_libraries(${target}PRIVATE SFML::Main) | ||
| target_link_options(${target}PRIVATE -u ANativeActivity_onCreate)# Prevent these from being stripped |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is something every user would have to do, so perhaps it should be set as a public property onSFML::Main instead so they don't have to?
ContributorAuthor
JonnyPtn commentedNov 25, 2025
I believe the window changes here should solve#3521 |
3 tasks
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Currently none of the examples work for Android, there's only a separate android example with lots of android specific code.
This is a draft to add an android project to SFML which can build and run the shared examples easily. Examples supported (Parity with iOS):
Project setup has an "SFML" module which declares the external native build to use our cmake setup, then a lightweight app module for each example, which is basically just an app manifest stating which shared library to run
Window creation changes
Window creation on android is asynchronous. This causes problems as when an
sf::Windowis created on android it's not actually valid until the callback is received and the egl surface can be created, which we do when polling events. The issue here is demonstrated by the window example, where we do stuff with the window before polling events and they fail.This PR changes window construction to wait for the window to actually be created. While blocking like this may not seem like a great idea the current implementation already blocks the application startup until the first
sf::Windowis created anyway so I don't think it's a big issue, and I'm not sure there are any alternatives without requiring users to add their own blocking code after window creation