I guess this can be removed, but what was the reason for it@JaceCear?

i would assume msvc

there is defines checking for it, but i would assume we arent compiling the tools in visual studio anyways

Looks like BriBaSA doesn't like it if it's not there?
1d0c7df

IMO keeping VS compat in turn means theoretical (and in this case practical) independence from GCC, which is a good thing.
I do prefer building with Visual Studio because it outputs proper PDBs, unlike the tool I use to convert GCC's debug info output.

Looks like BriBaSA doesn't like it if it's not there?1d0c7df

IMO keeping VS compat in turn means theoretical (and in this case practical) independence from GCC, which is a good thing. I do prefer building with Visual Studio because it outputs proper PDBs, unlike the tool I use to convert GCC's debug info output.

ok would !MSVC be a better choice then

Lol, so yeah this needs to be set if you are on windows?

yep,
fromtools/preproc/asm_file.cpp

i tried updating it but it randomly segfaults so this is the solution im using to work around that

// Asserts that the rest of the line is empty and moves to the next one.void AsmFile::ExpectEmptyRestOfLine(){    SkipWhitespace();    if (m_buffer[m_pos] == 0)    {        if (m_pos >= m_size)            RaiseWarning("file doesn't end with newline");        else            RaiseError("unexpected null character");    }    else if (m_buffer[m_pos] == '\n')    {        m_pos++;        m_lineStart = m_pos;        m_lineNum++;    }    else if (m_buffer[m_pos] == '\r')    {        RaiseError("only Unix-style LF newlines are supported");    }    else    {        RaiseError("junk at end of line");    }}

I don't like the workaround at all.
Either the code gets proper CRLF support or not, but dos2unix is an additional dependency that we don't need.

SDL can be included the normal way if you make the includes use the correct directory for the flags.

Where is your SDL library located to make this work? It is usingpkg-config sdl2?

I meant to set it to wip just because i knew i did this while working on it, but forgot to check the box