Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Alloc crate is not used, so no need to import it!#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Masterchef365 wants to merge1 commit intoRustPython:master
base:master
Choose a base branch
Loading
fromMasterchef365:no_std

Conversation

@Masterchef365
Copy link

@Masterchef365Masterchef365 commentedSep 11, 2025
edited by coderabbitaibot
Loading

Could theoretically have consequences if upstreamed, since it would allow compilation without the alloc crate. Probably has no effect for the RustPython project.

Summary by CodeRabbit

  • Refactor
    • Modernized internal dependency handling by removing an obsolete declaration, aligning with current compiler capabilities. No changes to functionality or public API.
  • Chores
    • Build cleanup to reduce maintenance overhead and improve compatibility with contemporary toolchains.
  • No User-Visible Changes
    • This update does not affect features, behavior, or performance.

@coderabbitai
Copy link

coderabbitaibot commentedSep 11, 2025
edited
Loading

Walkthrough

Removed the crate-levelextern crate alloc; declaration from src/lib.rs. No other edits, features, or public APIs were changed.

Changes

Cohort / File(s)Summary of Changes
Crate Declarations
src/lib.rs
Removedextern crate alloc; from the crate root; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Add no_std support #1 — Adjusts crate-level setup insrc/lib.rs by adding#![no_std] andextern crate alloc;, directly related to this PR’s removal ofextern crate alloc;.

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title accurately summarizes the primary change—the removal of an unused alloc import—and is a clear, single sentence that conveys the main intent to reviewers. It is specific, avoids noise, and aligns with the PR description and changes.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.

Poem

A nibble of code, a hop and a skip,
I plucked “extern crate alloc” from the tip.
Carrots aligned, imports now lean,
Rusty meadows tidy and clean.
Thump-thump—CI passes, what a delight!
A rabbit’s small change, compile-time light. 🥕

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see thedocumentation for more information.

Example:

reviews:pre_merge_checks:custom_checks:      -name:"Undocumented Breaking Changes"mode:"warning"instructions:|          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on thisDiscord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between8b1930b and8d34014.

📒 Files selected for processing (1)
  • src/lib.rs (0 hunks)
💤 Files with no reviewable changes (1)
  • src/lib.rs
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Masterchef365

[8]ページ先頭

©2009-2025 Movatter.jp