- Notifications
You must be signed in to change notification settings - Fork20
how to contribute by cpython unittest#6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
coolreader18 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great job, this is a really good guide!
| 1. At least it must be able to start to run the test. Fix the test code or bug until it runs at least a single unit of the test. Typically, unimplemented stdlib or missing files of unittest can make issues. Sometimes RustPython bugs make issues too. | ||
| 2. If any test is not loadable by `SyntaxError`, that part is required to be commented out. | ||
| 3. If any test leads to a crash of RustPython, this code is not possible to run. Mark the test to skip. | ||
| 4. If any test is run but fails, this is an incompatibility issue. Mark the test as an expected failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe mention the convention we have here ofTODO: RUSTPYTHON in skip messages orexpectedFailure comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I added that part
No description provided.