- Notifications
You must be signed in to change notification settings - Fork1.4k
Replace SSL backend to rustls#6244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| /// Formats raw IP address bytes according to standard notation: | ||
| /// - IPv4: dotted decimal (e.g., "192.0.2.1") | ||
| /// - IPv6: colon-separated hex (e.g., "2001:DB8:0:0:0:0:0:1") | ||
| fnformat_ip_address(ip:&[u8]) ->String{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Wouldn't make more sense to use one of:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
unfortunately ipv6 have different formatting.
Ipv6Addr format it like: "2001:DB8::1"
close#3839
close#5316