- Notifications
You must be signed in to change notification settings - Fork1.4k
ruff forExpr parsing#6207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
ruff forExpr parsing#6207
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This reverts commit153d0ee.
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ) | ||
| returnscope | ||
| @unittest.expectedFailure# TODO: RUSTPYTHON; 'a,' != '(a,)' |
ShaharNavehOct 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@youknowone should I open a feature request to ruff team about this? or should we just maintain our own fork of it? I am less in favor of maintaining a fork as it will require us:
- maintain a fork
- prevents us from publishing a new version to crates.io (unless we push the fork to crates.io)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
make a fork, write a feature but ask to merge it before using the fork. split the fork later when rejected. nothing to loose.
because we (and most of open source projects) always don't have enough engineering power for the project, upstreaming is the better choice when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's hope that they are fine with thisastral-sh/ruff#21041
Reverts#6206