You signed in with another tab or window.Reload to refresh your session.You signed out in another tab or window.Reload to refresh your session.You switched accounts on another tab or window.Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The changes update the set implementation and its tests. The Rust code for set difference updates now collects items to remove before deleting them, preventing iteration errors. The Python test removes an expected failure decorator from a test that checks in-place set operations, aligning behavior with CPython.
Changes
File(s)
Change Summary
Lib/test/test_set.py
Removed@unittest.expectedFailure and related comment fromtest_inplace_on_self inTestSet.
vm/src/builtins/set.rs
Modifieddifference_update to collect items into a vector before deletion, avoiding iteration errors.
Sequence Diagram(s)
sequenceDiagram participant Test as test_inplace_on_self participant PySet as PySetInner participant VM as VirtualMachine Test->>PySet: t = self.s.copy() Test->>PySet: t |= t (inplace or) Test->>PySet: t &= t (inplace and) PySet->>PySet: intersection_update Test->>PySet: t -= t (inplace difference) PySet->>PySet: difference_update (collect items, then delete) Test->>PySet: t ^= t (inplace xor) PySet->>PySet: symmetric_difference_update
Loading
Assessment against linked issues
Objective
Addressed
Explanation
Fix&= and-= operators between Set types to match CPython behavior (#3992)
In the garden of sets where the rabbits play, Bugs in&= and-= have hopped away! No more errors as we prune and we tend, Now in-place updates behave and blend. With every test passing, we leap with delight— Rust and Python, together just right! 🐇✨
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between8cac433 and739bc8d.
📒 Files selected for processing (2)
Lib/test/test_set.py (0 hunks)
vm/src/builtins/set.rs (1 hunks)
💤 Files with no reviewable changes (1)
Lib/test/test_set.py
🧰 Additional context used🧠 Learnings (1)📓 Common learnings
Learnt from: CRPR: RustPython/RustPython#0File: .github/copilot-instructions.md:0-0Timestamp: 2025-06-26T12:52:11.138ZLearning: Minimize modifications to CPython standard library files in the Lib/ directory; bug fixes should be made through Rust code modifications whenever possible.
⏰ Context from checks skipped due to timeout of 90000ms (11)
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Check the WASM package and demo
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Check Rust code with rustfmt and clippy
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Run tests under miri
GitHub Check: Run rust tests (windows-latest)
GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Run rust tests (macos-latest)
GitHub Check: Ensure compilation on various targets
🔇 Additional comments (1)
vm/src/builtins/set.rs (1)
428-430:Excellent fix for the "set changed size during iteration" issue.
The change correctly separates iteration from modification by collecting all items first usingcollect::<Result<Vec<_>, _>>() before performing deletions. This prevents the runtime error that occurs when a set's size changes during iteration.
The approach is sound because:
Errors during iteration are handled before any set modifications occur
The semantic behavior remains identical
It's consistent withsymmetric_difference_update which already uses a similar pattern
✨ Finishing Touches
📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.
Explain this complex logic.
Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
@coderabbitai explain this code block.
@coderabbitai modularize this function.
PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
@coderabbitai read src/utils.ts and explain its main purpose.
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on oursupport page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
Visit ourDocumentation for detailed information on how to use CodeRabbit.
Join ourDiscord Community to get help, request features, and share feedback.
Follow us onX/Twitter for updates and announcements.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This pull requestfixes#3992
Summary by CodeRabbit