- Notifications
You must be signed in to change notification settings - Fork1.3k
More tkinter#5784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
More tkinter#5784
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
@@ -272,8 +272,8 @@ mod _tkinter { | |||
// TODO: technically not thread safe | |||
let name = varname_converter(name, vm)?; | |||
let name = ffi::CString::new(name).unwrap(); | |||
let name2 = ffi::CString::new(name2.unwrap_or_default()).unwrap(); | |||
let name = ffi::CString::new(name)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I doubt this is buildable.
ToPyException requires vm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@arihant2math could you check this?
I still have no idea why getvar can't find tk_version and tcl_version, but that's an issue for another time.