Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updated test_fstring to 3.13.2#5749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
hbina wants to merge4 commits intoRustPython:main
base:main
Choose a base branch
Loading
fromhbina:hbina-fix-py313-test-fstring

Conversation

hbina
Copy link
Contributor

No description provided.

@hbinahbina changed the titleUpdated test_fstring to 3.12.2Updated test_fstring to 3.13.2Apr 27, 2025
@hbinahbinaforce-pushed thehbina-fix-py313-test-fstring branch fromd7d967f to83bf0cdCompareApril 27, 2025 10:14
@@ -542,12 +542,13 @@ impl Py<PyDict> {
key: &K,
vm: &VirtualMachine,
) -> PyResult<PyObjectRef> {
if let Some(value) = self.entries.get(vm, key)? {
let key = key.to_pyobject(vm);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

could you tell me more what was the motivation of this changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Okay, it seems this is not intended but accidently added to this branch.
Please clean up the branch to only contain fstring changes and push force it.

@hbinahbina marked this pull request as draftApril 30, 2025 12:52
@hbinahbinaforce-pushed thehbina-fix-py313-test-fstring branch from41253a2 to7148507CompareApril 30, 2025 15:42
@hbinahbinaforce-pushed thehbina-fix-py313-test-fstring branch from7148507 toae07b43CompareApril 30, 2025 15:51
@hbinahbina closed thisApr 30, 2025
@hbinahbina deleted the hbina-fix-py313-test-fstring branchApril 30, 2025 15:54
@hbinahbina restored the hbina-fix-py313-test-fstring branchApril 30, 2025 15:54
@youknowoneyouknowone reopened thisMay 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@youknowoneyouknowoneyouknowone left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hbina@youknowone

[8]ページ先頭

©2009-2025 Movatter.jp