Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implement nt.listvolumes#5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
arihant2math wants to merge1 commit intoRustPython:main
base:main
Choose a base branch
Loading
fromarihant2math:more-os

Conversation

arihant2math
Copy link
Collaborator

@arihant2matharihant2math commentedApr 21, 2025•
edited
Loading

  • nt.listvolumes
  • nt._path_exists and similar causes massive failures

@arihant2matharihant2mathforce-pushed themore-os branch 2 times, most recently frombfcd5ab to679af3fCompareApril 21, 2025 19:29
@arihant2matharihant2math marked this pull request as draftApril 22, 2025 04:57
@arihant2matharihant2math marked this pull request as ready for reviewApril 27, 2025 06:20
@youknowoneyouknowone changed the titleMore nt implementationnt.listvolumesApr 28, 2025
@youknowone
Copy link
Member

nt._path_exists doesn't look like to be included here.
I will not retrigger CI because nt is not related to ubuntu build

Copy link
Member

@youknowoneyouknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

was there any related test for listvolumes?

@arihant2math
Copy link
CollaboratorAuthor

was there any related test for listvolumes?

Yes, but it requires a different os function that doesn't exist, so it still fails.

youknowone reacted with thumbs up emoji

@arihant2matharihant2math changed the titlent.listvolumesImplement nt.listvolumesApr 30, 2025
#[pyfunction]
fn listvolumes(vm: &VirtualMachine) -> PyResult<PyListRef> {
let mut volumes = vec![];
let mut buffer = [0u16; 257];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If it is related to constant, is this possible?

Suggested change
letmut buffer =[0u16;257];
letmut buffer =[0u16;MAX_PATH +1];

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@youknowoneyouknowoneyouknowone left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@arihant2math@youknowone
[8]ページ先頭
©2009-2025 Movatter.jp