- Notifications
You must be signed in to change notification settings - Fork1.3k
lzma implementation#5717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
lzma implementation#5717
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This turned out surprisingly effective, about 2/3s of the tests pass, which is enough for me at the moment. The main missing parts involve a bunch of unsafe things that As a side note I also abstracted out |
c09442c to2bad5d2CompareLots of tests are failing because they were previously blocked due to no implementation at all. |
coolreader18 commentedApr 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Would you be able to squash these commits down? Ideally into one for copying the files from cpython, and one for all the rest? |
Sure |
19a43f5 toca2dc44CompareIt's at 3 now, I committed things in a weird fashion so I can't get it below that. |
Lib/tarfile.py Outdated
| @@ -392,7 +392,8 @@ def __init__(self, name, mode, comptype, fileobj, bufsize, | |||
| elif comptype == "xz": | |||
| try: | |||
| import lzma | |||
| # TODO: RUSTPYTHON remove underscore | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this name changed to raise ImportError? What happens if it islzma?
arihant2mathApr 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, if left as is everything breaks because lzma is expected to be unimportable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
xz seems to be not support. Added reason and avoided to use fake module name
oh no.. I thought#5728 and this one had shared work of the new compression module |
@arihant2math What will be the best way? Is it worth to keep#5728? |
Probably easiest to revert, yes. |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
79646fd intoRustPython:mainUh oh!
There was an error while loading.Please reload this page.
Based on#5709 because of the zlib abstraction.