- Notifications
You must be signed in to change notification settings - Fork1.3k
typing upgrade to 3.13.2#5590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The failing tests are unexpected success. Removing expectedFailure will fix them |
Rebasing has lead to an import error/compiler panic. |
That's because
Any chance to break one of them? |
hmmm. Blocking on#5622, so I can rewrite that in rust. |
Oh wait I can just break that import statement :D |
arihant2math commentedApr 5, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Blocked on#5628 so I can atleast partially fix codegen. |
One minor issue ... the pip install needs to be fixed. I can't really replicate on my machine because I'm on windows. |
|
youknowone commentedApr 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
While creating a class
The class is this one:https://github.com/pypa/pip/blob/24f4600851bbb3d7f22aed0ba6b1e2dcc4973412/src/pip/_vendor/rich/progress.py#L287-L305 |
youknowone commentedApr 22, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Reproducible code importtypingfromtypingimportContextManager,Generic,TextIO,BinaryIO_I=typing.TypeVar("_I",TextIO,BinaryIO)class_ReadContext(ContextManager[_I],Generic[_I]):pass |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Great, that's fixed. |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Finally, it all works. |
@youknowone do you mind reviewing please? |
Uh oh!
There was an error while loading.Please reload this page.
Even though there are regressions, merging this have benefits to fix pip |
d46bcd9
intoRustPython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes:#5584#5252
Closes:#4946