Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix io module being initialized multiple times#558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
windelbouwman merged 1 commit intoRustPython:masterfromsilmeth:io-import
Feb 26, 2019

Conversation

@silmeth
Copy link
Contributor

Fixes#557.

I wanted to test it somehow, but I am not sure how and whether I really should. Other modules are not tested for being imported once, and this one needs opening (ie. creating) a file (which is not portable to wasm, and litters user’s filesystem).

windelbouwman reacted with thumbs up emoji
@silmethsilmeth changed the titlefix io module being imported multiple timesfix io module being initialized multiple timesFeb 26, 2019
@codecov-io
Copy link

Codecov Report

Merging#558 intomaster willdecrease coverage by0.04%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #558      +/-   ##==========================================- Coverage   43.19%   43.14%   -0.05%==========================================  Files          72       72                Lines       15893    15899       +6       Branches     4172     4176       +4     ==========================================- Hits         6865     6860       -5- Misses       7106     7117      +11  Partials     1922     1922
Impacted FilesCoverage Δ
vm/src/stdlib/io.rs29.77% <100%> (-1.71%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec33abe9...5949a9b. Read thecomment docs.

@windelbouwmanwindelbouwman merged commita6341d3 intoRustPython:masterFeb 26, 2019
@silmethsilmeth deleted the io-import branchFebruary 26, 2019 20:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@silmeth@codecov-io@windelbouwman

[8]ページ先頭

©2009-2025 Movatter.jp