Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Socket improvments#545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
windelbouwman merged 6 commits intoRustPython:masterfrompalaviv:socket1
Feb 28, 2019
Merged

Conversation

@palaviv
Copy link
Contributor

  • socket.recv read amount of bytes asked
  • Add validation to connect and bind address

windelbouwman reacted with thumbs up emoji
@0b01
Copy link
Contributor

There are some linter warnings from your commit:

   --> vm/src/stdlib/socket.rs:182:43    |182 | fn socket_listen(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {    |                                           ^^^^ help: consider prefixing with an underscore: `_args`    |    = note: #[warn(unused_variables)] on by defaultwarning: unused variable: `bufsize`   --> vm/src/stdlib/socket.rs:226:36    |226 |         required = [(zelf, None), (bufsize, Some(vm.ctx.int_type()))]    |                                    ^^^^^^^ help: consider prefixing with an underscore: `_bufsize`warning: variant is never constructed: `UdpSocket`  --> vm/src/stdlib/socket.rs:53:5   |53 |     UdpSocket(UdpSocket),   |     ^^^^^^^^^^^^^^^^^^^^   |   = note: #[warn(dead_code)] on by default

@palaviv
Copy link
ContributorAuthor

@RickyHan I fixed the warnings.
I also addedgetsockname so I can pass 0 as port in the tests. I think that they failed because the port was on TIME_WAIT.

@windelbouwmanwindelbouwman merged commit6f2bbd2 intoRustPython:masterFeb 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@palaviv@0b01@windelbouwman

[8]ページ先頭

©2009-2025 Movatter.jp