Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add protocol object PyCallable#4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
youknowone merged 5 commits intoRustPython:mainfromyouknowone:pycallble
Mar 7, 2023

Conversation

youknowone
Copy link
Member

@youknowoneyouknowone commentedMar 7, 2023•
edited
Loading

@youknowoneyouknowone marked this pull request as ready for reviewMarch 7, 2023 10:45
}

#[inline]
pub fn is_callable(&self) -> bool {
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The newis_callable doesn't require vm argument anymore

Comment on lines +38 to +42
/// Trace events for sys.settrace and sys.setprofile.
enum TraceEvent {
Call,
Return,
}
Copy link
MemberAuthor

@youknowoneyouknowoneMar 7, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

relocatedTraceEvent because it is use only to call functions now.
if it will be going to be used somewhere else, i will createvm/src/trace.rs rather than putting it in vm.rs

@youknowoneyouknowone changed the titlePyCallableAdd protocol object PyCallableMar 7, 2023
Copy link
Contributor

@qingshi163qingshi163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great

@youknowoneyouknowone merged commit5a74f08 intoRustPython:mainMar 7, 2023
@youknowoneyouknowone deleted the pycallble branchMarch 7, 2023 20:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@qingshi163qingshi163qingshi163 approved these changes

@DimitrisJimDimitrisJimAwaiting requested review from DimitrisJim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@youknowone@qingshi163
[8]ページ先頭
©2009-2025 Movatter.jp