Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Correct exitcode of KeyboardInterrupt#4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
youknowone merged 1 commit intoRustPython:mainfrommoreal:keyboard-int-exitcode
Jan 8, 2023

Conversation

@moreal
Copy link
Contributor

@morealmoreal commentedJan 3, 2023•
edited
Loading

This pull requests fixes exitcode ofKeyboardInterrupt. You can run the below code with CPython and RustPython(before/after). (in unix target os)

# RUSTPYTHONcargo run -- -c "raise KeyboardInterrupt"echo $?  # before = 1 / after = 130# CPYTHONpython3 -c "raise KeyboardInterrupt"echo $?  # 130

Tasks

Related links

DimitrisJim and youknowone reacted with thumbs up emoji
self.print_exception(exc);
#[cfg(windows)]
{
winapi::winnt::STATUS_CONTROL_C_EXIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe adding a feature related to winnt will be helpful

moreal reacted with eyes emoji
@morealmorealforce-pushed thekeyboard-int-exitcode branch 6 times, most recently from83bf3e8 to2444961CompareJanuary 8, 2023 05:18
@moreal
Copy link
ContributorAuthor

I tried to implement for targets (not unix) but there were some issues:

So this pull request became to implement only for unix now. Other pull request will resolve the problem in windows and wasm instead.

@morealmorealforce-pushed thekeyboard-int-exitcode branch from2444961 to3f98f68CompareJanuary 8, 2023 05:33
@morealmoreal marked this pull request as ready for reviewJanuary 8, 2023 05:35
@morealmorealforce-pushed thekeyboard-int-exitcode branch from3f98f68 to16579aeCompareJanuary 8, 2023 05:49
Copy link
Member

@youknowoneyouknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@youknowoneyouknowoneyouknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moreal@youknowone
[8]ページ先頭
©2009-2025 Movatter.jp